New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible risk of temporary file collision #191

Open

JensRantil opened this issue Oct 25, 2020 · 1 comment

JensRantil commented Oct 25, 2020

I'm reading

gleam/filesystem/vfs_s3.go

Line 83 in 766b221

filename := fmt.Sprintf("%s/s3_%d", os.TempDir(), rand.Uint32())

and

gleam/filesystem/vfs_gs.go

Line 108 in 53a6956

filename := fmt.Sprintf("%s/gs_%d", os.TempDir(), rand.Uint32())

and both has a slight risk of file name collisions. I propose migrating to use https://golang.org/pkg/io/ioutil/#TempFile which makes that scenario impossible.

Owner

chrislusf commented Oct 25, 2020

Send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment