size issue with easy fix

[jpkoc]

Hi,
The issue is related to the resulting image size produced by: images_vconcat() and images_hconcat() in nb_setup.py
I believe that the (width, height) argument of thumbnail() should be set to:
new_im.thumbnail((width, height), pimage.ANTIALIAS) should be replaced by:
new_im.thumbnail((total_width,max_height), pimage.ANTIALIAS)

Thanks for validating and updating your code if correct

[chrisjsewell]

@jpkoc thanks for the feedback, I will have a look soon

[jpkoc]

Thanks! By the way, my statement was not totally ciorrect. Here is what (I believe) the correct settings are: For images_hconcat new_im.thumbnail((total_width,max_height), pimage.ANTIALIAS) For images_vconcat new_im.thumbnail((total_height,max_width), pimage.ANTIALIAS)

…

On Dec 9, 2019, at 2:32 AM, Chris Sewell ***@***.***> wrote: @jpkoc <https://github.com/jpkoc> thanks for the feedback, I will have a look soon — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#124?email_source=notifications&email_token=ADJZWL3AO7KAGMZYFP75KLLQXX7ATA5CNFSM4JX3TRN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGIJBQQ#issuecomment-563122370>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADJZWL6UJUU3MDK6MFQF2ODQXX7ATANCNFSM4JX3TRNQ>.