Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linking directly to clips. #1

Open
chrisfried opened this issue Mar 11, 2017 · 6 comments
Open

Support linking directly to clips. #1

chrisfried opened this issue Mar 11, 2017 · 6 comments

Comments

@chrisfried
Copy link
Owner

No description provided.

@jbccollins
Copy link
Contributor

Is the idea here to have a link that directs the user to an external url? Something like
screen shot 2017-03-26 at 11 43 04 am

Which when you click it would open https://boiling-chamber-45794.herokuapp.com/clip/[gamertag]/
[clip-uuid] in a new tab?

Or do you want a new clip component that basically just contains that standalone video tag and is reachable via a new guardian.theater url (something like guardian.theater/clip/[platform]/[gamertag]/[clip-uuid])

@chrisfried
Copy link
Owner Author

Closer to the latter. Clicking on the clip name / "Xbox Game DVR Clip" would take you to a route that displays the clip and the activity the clip was recorded in.

I'd say the URL should look more like a child of the activity the clip belongs to: /activity/[platform]/[activityId]/[gamertag]/[clipId]

The page would autoplay the clip at the top of the page, and below show the activity and any other clips.

@chrisfried
Copy link
Owner Author

In an ideal world, no one links directly to the boiling-chamber URLs. They exist for gif making (imgur doesn't like the actual Xbox URLs) and social media embeds (which have yet to be reimplemented).

@jbccollins
Copy link
Contributor

jbccollins commented Mar 28, 2017

Any particular reason not to link directly to the xbox dvr site when clicking on the xbox banner? Like how clicking on the twitch banners works.

@chrisfried
Copy link
Owner Author

Last I looked, I couldn’t find a way to link to a video page on xbox.com. The videos live in modal popups without routes. If you can find a way to do it, I’m on board.

@chrisfried
Copy link
Owner Author

Unless you meant to link straight to the video files, which is also out, as those URLs don't last very long before expiring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants