Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core/Composite: Simplify Composite.context #156

Open
chr5tphr opened this issue Jul 14, 2022 · 0 comments
Open

Core/Composite: Simplify Composite.context #156

chr5tphr opened this issue Jul 14, 2022 · 0 comments
Labels
core Feature/bug concerning core functionality enhancement New feature or request

Comments

@chr5tphr
Copy link
Owner

chr5tphr commented Jul 14, 2022 •
edited

Composite.context can be implemented slimmer/simpler using contextlib.contextmanager.
Furthermore, instead of calling Composite.context, the same functionality could be implemented as Composite.__call__, as the context is the main functionality, and this would remove a little bit of overhead, although .context may be more descriptive.
@chr5tphr chr5tphr added enhancement New feature or request core Feature/bug concerning core functionality labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Feature/bug concerning core functionality enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chr5tphr