Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reducing nbclean dependencies #13

Open
betatim opened this issue Sep 28, 2018 · 3 comments
Open

reducing nbclean dependencies #13

betatim opened this issue Sep 28, 2018 · 3 comments

Comments

@betatim
Copy link
Collaborator

betatim commented Sep 28, 2018

In a circleCI with their python:3.7 image I ended up with ipython v7 and an old version of prompt_toolkit. I haven't yet tracked down what is causing the conflict, limiting myself to ipython 6 seems to do the trick for now.

This made me look at the dependencies that were being installed. Which made me wonder: does nbclean need to depend on numpy and tqdm and nbgrader?

TL;DR: can we work on reducing the dependencies of nbclean to a very small number of libraries that are very actively maintained?

@choldgraf
Copy link
Owner

I'm all for it - the heaviest dependency is definitely nbgrader, which has the logic for replacing text etc (and is the reason nbclean uses traitlets syntax which I'm not a huge fan of TBH). I do agree this could probably be reduced and would make the package more lightweight/maintainable

@betatim
Copy link
Collaborator Author

betatim commented Sep 29, 2018

Let's see if we can extract/make our own version of the text replacement.

@choldgraf
Copy link
Owner

PRs are welcome ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants