Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hexen: autosaves cause problems with -demoextend multi-level demos #1662

Open
kitchen-ace opened this issue Jan 27, 2024 · 2 comments
Open

Comments

@kitchen-ace
Copy link
Contributor

In Hexen, when you go to a new level, the game creates an internal autosave. (This is vanilla behaviour.)

Chocolate supports the -demoextend parameter to record demos across multiple levels, however if you enter a new level that already has an existing autosave, you may just immediately die instead.

example: chocolate-hexen -warp 4 -demoextend -skill 4 -class 0 -record test.lmp and then move backwards to go through the portal. If you do this once (and have no prior autosaves for that level) it will work fine. If you then do it a second time (even with a different demo name), you'll die on going to the new level. Deleting all files in the chocolate-hexen save directory will let you record a demo properly once again.

Tested with the most recent git version, and a few previous versions.

@turol
Copy link
Member

turol commented Jan 30, 2024

Changing this line:

if (!deathmatch && ExistingFile(fileName))

To this:

if (!demorecording && !deathmatch && ExistingFile(fileName))

Makes it work for me. Can you check if this breaks anything else?

@turol
Copy link
Member

turol commented Jan 30, 2024

I think that is not the correct fix. I think we should add a call to SV_InitBaseSlot somewhere in the demo recording code to remove those old saves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants