Skip to content

Commit

Permalink
Simpler ID match
Browse files Browse the repository at this point in the history
  • Loading branch information
Chocobozzz committed Oct 11, 2021
1 parent c55d762 commit e5d9877
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions server/middlewares/validators/oembed.ts
Expand Up @@ -28,7 +28,6 @@ function buildUrls (paths: string[]) {
const startPlaylistURLs = buildUrls(playlistPaths)
const startVideoURLs = buildUrls(videoPaths)

const watchRegex = /\/([^/]+)$/
const isURLOptions = {
require_host: true,
require_tld: true
Expand Down Expand Up @@ -81,9 +80,9 @@ const oembedValidator = [

const startIsOk = isVideo || isPlaylist

const matches = watchRegex.exec(urlPath)
const parts = urlPath.split('/')

if (startIsOk === false || matches === null) {
if (startIsOk === false || parts.length === 0) {
return res.fail({
status: HttpStatusCode.BAD_REQUEST_400,
message: 'Invalid url.',
Expand All @@ -93,7 +92,7 @@ const oembedValidator = [
})
}

const elementId = toCompleteUUID(matches[1])
const elementId = toCompleteUUID(parts.pop())
if (isIdOrUUIDValid(elementId) === false) {
return res.fail({ message: 'Invalid video or playlist id.' })
}
Expand Down

0 comments on commit e5d9877

Please sign in to comment.