Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngx_murmurhash.c error how to fix? #285

Open
thestarrypage opened this issue Sep 24, 2023 · 1 comment
Open

ngx_murmurhash.c error how to fix? #285

thestarrypage opened this issue Sep 24, 2023 · 1 comment

Comments

@thestarrypage
Copy link

0. Before Your ASK

  1. Try to find an answer by reading a FAQ.

Ⅰ. Issue Description

When running make && makeinstall

src/core/ngx_murmurhash.c: In function ‘ngx_murmur_hash2’:
src/core/ngx_murmurhash.c:37:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
   37 |         h ^= data[2] << 16;
      |         ~~^~~~~~~~~~~~~~~~
src/core/ngx_murmurhash.c:38:5: note: here
   38 |     case 2:
      |     ^~~~
src/core/ngx_murmurhash.c:39:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
   39 |         h ^= data[1] << 8;
      |         ~~^~~~~~~~~~~~~~~

Ⅱ. Describe what happened

No idea what is this error

Ⅲ. Describe what you expected to happen

to be able to build

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Follow exacts same steps

$ wget http://nginx.org/download/nginx-1.9.12.tar.gz
$ tar -xzvf nginx-1.9.12.tar.gz
$ cd nginx-1.9.12/
$ patch -p1 < /path/to/ngx_http_proxy_connect_module/patch/proxy_connect.patch
$ ./configure --add-dynamic-module=/path/to/ngx_http_proxy_connect_module
$ make && make install

Ⅴ. Anything else we need to know?

  1. If applicable, add nginx debug log.

Ⅵ. Environment:

  1. Tengine/Nginx/OpenResty version (use sbin/nginx -v):
  2. Which patch do you use?
@chobits
Copy link
Owner

chobits commented Nov 27, 2023

See here: arut/nginx-rtmp-module#1255

Two methods could be used to fix:

  1. Getting error on make command Ubuntu 18.04 arut/nginx-rtmp-module#1255 (comment)
  2. use higher version of nginx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants