Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless extmodule port name checks #2438

Closed
wants to merge 1 commit into from
Closed

Remove useless extmodule port name checks #2438

wants to merge 1 commit into from

Conversation

johnsbrew
Copy link
Contributor

Fixes #2437

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add remove at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

bug fix

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

Squash

Release Notes

Remove useless extmodule port name checks
See #2437

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@johnsbrew
Remove useless extmodule port name checks
f6be356 
Signed-off-by: Jean Bruant <jean.bruant@ovhcloud.com>
@johnsbrew
Copy link
Contributor Author

Declining this PR as it does not really solve the underlying issue behind #2437

@johnsbrew johnsbrew closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extmodule port name check fails with length-parameterized Vec ports
1 participant
@johnsbrew