Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ignore undeserializable annotations (basically pass them through) #2384

Open
3 tasks
jackkoenig opened this issue Oct 11, 2021 · 2 comments
Open
3 tasks
Assignees

Comments

@jackkoenig
Copy link
Contributor

Checklist

  • Did you write out a description of the feature you want to see?
  • Did you look around for any related features?
  • Did you specify relevant external information?

Feature Description

Type of Feature

Related Features

External Information

@jackkoenig
Copy link
Contributor Author

jackkoenig commented Oct 12, 2021

For implementing this, the basic problem is trying to deserialize a whole List[Annotation] at once:

To do this, we need to deserialize one-by-one.

This is basically the inverse of

val safeAnnos = annos.map { anno =>
which is doing it for serialization (only used by logging).

@jackkoenig
Copy link
Contributor Author

@davidbiancolin has noted that package-level allow and disallow lists may be useful here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants