Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage instructions for ReplSeqMemsAnnotation are incorrect #2351

Open
4 of 5 tasks
mwachs5 opened this issue Sep 7, 2021 · 1 comment
Open
4 of 5 tasks

Usage instructions for ReplSeqMemsAnnotation are incorrect #2351

mwachs5 opened this issue Sep 7, 2021 · 1 comment

Comments

@mwachs5
Copy link
Contributor

mwachs5 commented Sep 7, 2021

Checklist

  • Did you specify the current behavior?
  • Did you specify the expected behavior?
  • Did you provide a code example showing the problem?
  • Did you describe your environment?
  • Did you specify relevant external information?

What is the current behavior?

The usage string for ReplSeqMems says:

  --replSeqMem -c:<circuit>:-i:<filename>:-o:<filename>
  *** Note: sub-arguments to --replSeqMem should be delimited by : and not white space!
Required Arguments:
  -o<filename>         Specify the output configuration file
  -c<circuit>          Specify the target circuit

What is the expected behavior?

The actual argument is --repl-seq-mem.
It's also unclear to me if -c option is still correct/usable (@sequencer was this changed in #2191 ?)

Steps to Reproduce

Your environment

  • Chisel Verions: master
  • OS:
  • Verilator version:

External Information

@sequencer
Copy link
Member

I was confused by this when I refactoring it, it seems memlib didn't use parsed circuit.

However, after my checking to this API again, I found it was because of ClockListTransform using PassConfigUtil in:

val passCircuit = passOptions.getOrElse(
PassCircuitName,
error("No circuit name specified for ClockList!" + usage)
)
, I cannot remove -c parser(although I want to do this)

Personally I think -c can be removed if we use memlib. But for not breaking backward compatibility, I keep -c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants