Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data directory for "bet" for reading cashier/dealer and RPC API config info #233

Open
satindergrewal opened this issue Jun 23, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@satindergrewal
Copy link
Collaborator

satindergrewal commented Jun 23, 2021

Right now bet is communicating with c-lightning and chips via CLI commands.

This must be updated to instead use RPC communication, so that bet does not rely on command line path settings etc and be working independently. RPC specific issue can be tracked here: #179

For "bet" specific data directory based on different platforms, I'd suggest to make a data directory for bet specific configuration files. Like for different OS, it should be like:

  • Linux: $HOME/.chipsbet/
  • macOS: $HOME/Library/Applications Support/Chipsbet/
  • Windows: %AppData%\Chipsbet

And under this bet's data directory we can move files located from privatebet/config/ directory:

cashier_nodes.json
dealer_config.json

There we can also have the chipsbet.conf file created to get the RPC information for both c-lightning and Chips. Example:

CHIPS_RPC_IP=127.0.0.1
CHIPS_RPC_PORT=57776
CHIPS_RPC_USER=chip_rpc_username
CHIPS_RPC_PASSWORD=chips_rpc_password

# c-lightning only provides JSON-RPC socket, and no HTTP RPC API
CHIPS_C_LIGHTNING_RPC_SOCKET=/home/username/.chipsln/chips/chipsln-rpc
@satindergrewal satindergrewal added the enhancement New feature or request label Jun 23, 2021
@satindergrewal satindergrewal added this to To do in Multiplayer release via automation Jun 23, 2021
@satindergrewal satindergrewal self-assigned this Jun 23, 2021
@satindergrewal satindergrewal added this to the 0.0.1 - First beta milestone Jun 23, 2021
@satindergrewal satindergrewal changed the title Replace third party applications communication via APIs instead of CLI commands Using system specific data directory for "bet" for reading cashier/dealer and RPC API config info Jun 23, 2021
@satindergrewal satindergrewal changed the title Using system specific data directory for "bet" for reading cashier/dealer and RPC API config info Data directory for "bet" for reading cashier/dealer and RPC API config info Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant