Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change storage interface to take a slice of peers as input #569

Open
shyba opened this issue Apr 25, 2022 · 0 comments
Open

Change storage interface to take a slice of peers as input #569

shyba opened this issue Apr 25, 2022 · 0 comments

Comments

@shyba
Copy link
Contributor

shyba commented Apr 25, 2022

From a previous discussion on #566, @mrd0ll4r commented:

(...)Thinking about it some more, the most elegant approach would be to pass a (possibly non-empty) slice of bittorrent.Peer to the storage to fill up to numWant, but we can't do that with the current interfaces. (...)

The relevant interface part is AnnouncePeers, from storage.go, with updates to everything implementing it (Redis and memory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant