Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal errors might be reported to clients #474

Open
mrd0ll4r opened this issue Mar 13, 2020 · 2 comments
Open

Internal errors might be reported to clients #474

mrd0ll4r opened this issue Mar 13, 2020 · 2 comments
Labels
kind/enhancement

Comments

@mrd0ll4r
Copy link
Member

This was the case for the redis storage implementation, and it's probably also true for anything else on the announce path that can produce errors.
I think we should come up with something to mark an error as "client-safe" to avoid exposing our internals...
@jzelinskie
Copy link
Member

This is exactly what ClientError does?

@mrd0ll4r
Copy link
Member Author

That's weird 🤔 I could have sworn I saw storage-internal errors on the client.. will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jzelinskie @mrd0ll4r