Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to compile on Debian 8 #75

Open
aunali1 opened this issue Apr 10, 2017 · 5 comments
Open

Fails to compile on Debian 8 #75

aunali1 opened this issue Apr 10, 2017 · 5 comments
Assignees
@aunali1

Comments

@aunali1
Copy link
Member

aunali1 commented Apr 10, 2017 •
edited

Due to the lack of target_compile_features support in CMake 3.0.2, which happens to be the version shipped with Debian 8, chigraph fails to compile

-- clang install prefix: /usr/lib/llvm-3.5
-- clang libdir: /usr/lib/llvm-3.5/lib
CMake Error at libchigraph/CMakeLists.txt:51 (target_compile_features):
  Unknown CMake command "target_compile_features".


-- Configuring incomplete, errors occurred!
See also "/home/aunali/chigraph/build/CMakeFiles/CMakeOutput.log".
See also "/home/aunali/chigraph/build/CMakeFiles/CMakeError.log".
aunali@debian-kvm:~/chigraph/build$ cmake --version
cmake version 3.0.2

CMake suite maintained and supported by Kitware (kitware.com/cmake).
aunali@debian-kvm:~/chigraph/build$
@aunali1 aunali1 self-assigned this Apr 10, 2017
@aunali1
Copy link
Member Author

aunali1 commented Apr 10, 2017

Currently working on a solution. Will PR in a few mins.

aunali1 added a commit to aunali1/chigraph that referenced this issue Apr 10, 2017
@aunali1
cmake: Fix C++11 feature detection for pre-3.1 CMake
624b599 
With older versions of Cmake, pre-3.1, the feature detection macro,
target_compile_features, is not available. As a side effect, distributions
like Debian 8 cannot compile Chigraph due to their old versions of CMake.

This commit adds a features detection scheme that supports the commonly used
C++11 features and works with CMake versions as far back as 2.8.3. Additionally,
this variant is conditionally used and target_compile_features is favored when
available.

ISSUE: chigraph#75
TEST: Configuration succeeds on Debian 8 (CMAKE 3.0.2)

Tested-by: Aun-Ali Zaidi <admin@kodeit.net>
Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net>
@aunali1 aunali1 mentioned this issue Apr 10, 2017
Merged
@aunali1 aunali1 reopened this Apr 11, 2017
@russelltg
Copy link
Member

Does this require support for LLVM 3.6?

@aunali1
Copy link
Member Author

aunali1 commented Apr 16, 2017 •
edited

The version distributed by Debian 8 is 3.5.

@russelltg
Copy link
Member

russelltg commented May 2, 2017 •
edited 

$ chi compile main.chimod  | lli
Num:0Num:1Num:2Num:3Num:4Num:5Num:6Num:7Num:8Num:9Num:10Num:11123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999

@russelltg
Copy link
Member

Now just to get chi run to work :)

russelltg pushed a commit that referenced this issue May 7, 2017
@aunali1
cmake: Fix C++11 feature detection for pre-3.1 CMake
2550995 
With older versions of Cmake, pre-3.1, the feature detection macro,
target_compile_features, is not available. As a side effect, distributions
like Debian 8 cannot compile Chigraph due to their old versions of CMake.

This commit adds a features detection scheme that supports the commonly used
C++11 features and works with CMake versions as far back as 2.8.3. Additionally,
this variant is conditionally used and target_compile_features is favored when
available.

ISSUE: #75
TEST: Configuration succeeds on Debian 8 (CMAKE 3.0.2)

Tested-by: Aun-Ali Zaidi <admin@kodeit.net>
Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net>
russelltg pushed a commit that referenced this issue May 7, 2017
@aunali1
cmake: Fix C++11 feature detection for pre-3.1 CMake
f6d3356 
With older versions of Cmake, pre-3.1, the feature detection macro,
target_compile_features, is not available. As a side effect, distributions
like Debian 8 cannot compile Chigraph due to their old versions of CMake.

This commit adds a features detection scheme that supports the commonly used
C++11 features and works with CMake versions as far back as 2.8.3. Additionally,
this variant is conditionally used and target_compile_features is favored when
available.

ISSUE: #75
TEST: Configuration succeeds on Debian 8 (CMAKE 3.0.2)

Tested-by: Aun-Ali Zaidi <admin@kodeit.net>
Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aunali1 aunali1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aunali1 @russelltg