Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename aarch64 to arm64 on Linux. #2

Merged
merged 1 commit into from
Feb 24, 2023
Merged

fix: rename aarch64 to arm64 on Linux. #2

merged 1 commit into from
Feb 24, 2023

Conversation

jimsynz
Copy link
Contributor

@jimsynz jimsynz commented Feb 22, 2023

Closes #1.

Copy link
Owner

@chessmango chessmango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Glad to see this is in use somewhere as well :)
Just suggesting being less specific for ease, and then in case something other than Linux reports aarch64 for whatever reason.

lib/utils.bash Outdated Show resolved Hide resolved
@jimsynz
Copy link
Contributor Author

jimsynz commented Feb 23, 2023

Thanks man. Yeah, I use ASDF in all my devcontainers because we can manage the environment from a single tool versions file. Had a client that deploys via fly - easy enough to add to the container this way.

@chessmango chessmango merged commit 7352c16 into chessmango:main Feb 24, 2023
@chessmango
Copy link
Owner

Thanks man. Yeah, I use ASDF in all my devcontainers because we can manage the environment from a single tool versions file. Had a client that deploys via fly - easy enough to add to the container this way.

Very cool. I'm trying to find ways to have my org do the same, but plugin quality varies pretty wildly. Mine probably aren't the greatest either ;) though I try to keep things consistent at least

Thanks again for the PR!

@jimsynz jimsynz deleted the fix/linux-aarch64 branch February 24, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 error on Linux arm64.
2 participants