Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Daemonizer is changing log files access to World write #2000

Open
1 task
J-Visu opened this issue Sep 6, 2023 · 1 comment
Open
1 task

Enabling Daemonizer is changing log files access to World write #2000

J-Visu opened this issue Sep 6, 2023 · 1 comment

Comments

@J-Visu
Copy link

J-Visu commented Sep 6, 2023

I'm submitting a ...

  • bug report

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
When I'm enabling Daemonizer "Daemonizer(cherrypy.engine).subscribe()", I see the log files permissions are changing to -rw-rw-rw- on rollover.
When I start the server, the log files are created with -rw-r----- but with roll over based on time, the new rollover files gets file permission as -rw-rw-rw-.
When I do not enable Daemonizer, I do not see any change in file permission on rollover.

If the current behavior is a bug, please provide the steps to reproduce and if possible a screenshots and logs of the problem. If you can, show us your code.
The steps are easy to reproduce. Adding Daemonizer to a log rollover server should reproduce the issue.
Will share the sample program if needed.

What is the expected behavior?
No.

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Cheroot version: X.X.X
  • CherryPy version: X.X.X
  • Python version: 3.6.X
  • OS: XXX
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, e.g. stackoverflow, gitter, etc.)

@webknjaz
Copy link
Member

That's interesting... I don't see this being done explicitly @ https://github.com/cherrypy/cherrypy/blob/6387a2b/cherrypy/process/plugins.py#L337-L424.

Perhaps a full repro would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants