Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Timing tool example and before_handler docs improvement. #1990

Open
Duiesel opened this issue Mar 26, 2023 · 4 comments
Open

Bug in Timing tool example and before_handler docs improvement. #1990

Duiesel opened this issue Mar 26, 2023 · 4 comments
Labels
CherryPy documentation reproducer: missing This PR or issue leaks code, which reproduce the problem described or clearly understandable STR

Comments

@Duiesel
Copy link

Duiesel commented Mar 26, 2023

Hi guys!

I found an error in documentation related to TimingTool example.

before_handler never happens if there are an error at request body processing step.

So suggesting improvement of TimingTool example and before_handler event in docs.

@Duiesel Duiesel changed the title Bug inTiming tool example and before_handler docs improvement. Bug in Timing tool example and before_handler docs improvement. Mar 26, 2023
@webknjaz
Copy link
Member

@Duiesel are you suggesting that this causes an AttributeError? Could you post a little STR / demonstration?
Would you like to suggest a PR with a fix?

@webknjaz webknjaz added CherryPy documentation reproducer: missing This PR or issue leaks code, which reproduce the problem described or clearly understandable STR labels Mar 26, 2023
@Duiesel
Copy link
Author

Duiesel commented May 9, 2023

It causes nothing and this is the case.
If you get any error at request body processing step, any tool attached to hook point before_handler never called.
So it's not obvious and documentation says nothing about it.
I've looked at source code to figure out what happened.

Anyway will do a PR with a docs improvement.

@Duiesel
Copy link
Author

Duiesel commented May 9, 2023

@webknjaz If needed I could add simple example.

@webknjaz
Copy link
Member

webknjaz commented May 9, 2023

I think you can go ahead and just submit an improvement PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPy documentation reproducer: missing This PR or issue leaks code, which reproduce the problem described or clearly understandable STR
Projects
None yet
Development

No branches or pull requests

2 participants