Fix: Portfolio site leads to 404 #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@novellac The next step is to find where to wrap the url with this function once you approve of the function. |
TishG
force-pushed
the
fix/website/147-portfolio-site-leads-to-404
branch
2 times, most recently
from
e681ba9
to
0208bdb
Compare
TishG
force-pushed
the
fix/website/147-portfolio-site-leads-to-404
branch
from
0208bdb
to
78113f7
Compare
novellac
reviewed
Feb 23, 2022
Comment on lines
+97
to
+104
| // methods: { | ||
| // validUrl | ||
| // }, | ||
| // computed: { | ||
| // portfolioUrl() { | ||
| // // return this.validUrl(member.node.contact_links.portfolio_url) | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Suggestion: Remove these unused methods.
novellac
reviewed
Feb 23, 2022
| @@ -16,13 +16,13 @@ | |||
| /> | |||
| <a | |||
| v-if="$page.biopost.contact_links.email" | |||
| :href="`mailto:${$page.biopost.contact_links.email}`" | |||
| href="`mailto:${$page.biopost.contact_links.email}`" | |||
There was a problem hiding this comment.
I think here we still want the email to be dynamic, so keep the : on the href.
novellac
reviewed
Feb 23, 2022
Comment on lines
+12
to
+14
| * Our CMS does not validate urls, | ||
| * urls are entered in manually by the author, | ||
| * so this is to ensure a valid url to navigate to |
There was a problem hiding this comment.
Compliment: I like your explanation here, it gives great context.
novellac
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes...
This PR fixes #147. Appends 'https://' to the urls that do not have 'http://' or 'https://' so that the link navigates to the site instead of 404 error page.
What I did...
How to test...