Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max width in layout #123

Open
novellac opened this issue Jan 23, 2021 · 0 comments
Open

Set max width in layout #123

novellac opened this issue Jan 23, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@novellac
Copy link
Contributor

Yikes! Briefly, what seems wrong?
We currently don't have a max width set on layout; we have been setting it in individual pages and I'd like to stop this (it's my fault for starting us down this road!).
馃洃 Blocker: Once #120 is merged, I think we'll be in a better place to address this. #120 implements a header slot in the default layout, and this should allow us to style the content below the header.

Expected Behavior
Pages should (excluding the header and any CTAs) have a max width of TW large (1024px).

Current Behavior
Currently you must implement max widths on a per-page basis. 馃槵

Possible Solution
Add the max-width large to the default layout.

Steps to Reproduce
Compare the /dictionary page with the /about page. On the /dictionary page, no max width has been set. On the /about page, you can see a max width large.

@novellac novellac added the bug Something isn't working label Jan 23, 2021
@project-bot project-bot bot added this to To do in Website Project Board Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant