Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Refactor Predictor subclasses into parameterizations via OutputTransforms #811

Open
hwpang opened this issue Apr 18, 2024 · 0 comments
Labels
enhancement a new feature request todo add an item to the to-do list
Milestone

Comments

@hwpang
Copy link
Contributor

hwpang commented Apr 18, 2024

Notes
From @davidegraff 's comment from #726

  1. Expressing our Predictor subclasses as parameterizations of a base Predictor using different OutputTransforms rather than separate subclasses. For instance, a BinaryClassificationFFN is functionally the same as a RegressionFFN with the only differences of:

    • use of a BCE loss function
    • use of a sigmoid activation activation at test-time rather than an inverse normalization (i.e., a SigmoidTransform)
@hwpang hwpang added the todo add an item to the to-do list label Apr 18, 2024
@hwpang hwpang changed the title [V2][TODO]: [V2][TODO]: Expressing our Predictor subclasses as parameterizations of a base Predictor using different OutputTransform Apr 18, 2024
@davidegraff davidegraff changed the title [V2][TODO]: Expressing our Predictor subclasses as parameterizations of a base Predictor using different OutputTransform [Feature]: Refactor Predictor subclasses into parameterizations via OutputTransforms Apr 18, 2024
@davidegraff davidegraff added the enhancement a new feature request label Apr 18, 2024
@KnathanM KnathanM added this to the v2.1.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a new feature request todo add an item to the to-do list
Projects
None yet
Development

No branches or pull requests

3 participants