-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMQC zones picking (manual) leads to crash #785
Comments
@nes-cgn |
I tried the latest version, problem continues. The notebook is quite powerful, I do not think it is a processor issue. |
@nes-cgn could you check if this was improved? |
I am looking for a solution. I found that we pass to the method all the intensity range. we could handle the problem with noiseFactor e.g for auto detection with noiseFactor equal to 5 I got the next picture it is not still the best result but it is better, I am trying to understand why the method depends in this way of noiseFactor |
Well, as I mentioned - it is primitive, but if you look at the "-new2" picture three graphs above, in the worst of all cases, one could define an option that sets the centre of a (manually defined) region as the picked peak. That is by no means automatic recognition, but at least, like that you could add a value in critical cases where other attempts fail |
Apparently, this problem is fixed, could you have a look? |
In the following example (HMQC from nmr-dataset1 case 2591-86-8), automatic zones picking does not allow a meaningful result. So, the picking needs to be done manually. And in that case, the three signals in the upper right corner of the correlation (see expansion 2 from attached files) always leads to a crash, if I try to select the three individual cross peaks for zone definition...
hmqc-light.zip
The text was updated successfully, but these errors were encountered: