feat: zoom out based on defined axis domain preferences #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamed-musallam
force-pushed
the
hardcoded-axis-values
branch
from
29a412a
to
5a73475
Compare
Deploying nmrium with
|
| Latest commit: |
d9f80b0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b35cdfa0.nmrium.pages.dev |
| Branch Preview URL: | https://hardcoded-axis-values.nmrium.pages.dev |
lpatiny
requested changes
Apr 28, 2024
|
I am still convinced that the domain preferences should be in the general settings and not in the spectra panel preferences, the panel preferences are only for the panel itself and not a general setting that is applied over the displayer. I think it could be somewhere in the general settings under the General tab or we could have a separate tab
|
|
If you believe it's preferable to keep axis domain preferences in the spectra panel preferences, please inform me so I can generate a new release of nmr-load-save and merge this pull request. |
|
It would certainly make sense that the from / to is defined per nucleus and is not different when we have couple of nuclei. So in this case we only need to specify 1H, 13C, 19F, ... Something like
|
Define the axis domain (x-axis for one-dimension spectra and x-axis, y-axis for two-dimension spectra) from the spectra panel preferences. Once it is defined, use Shift + f to zoom out. close #3024
chore: update to nmr-load-save version 0.31.0 refactor: 'Formatting' tab preferences and rename it to 'Nuclei' refactor: formatting object in the workspace and the predefined workspaces
hamed-musallam
force-pushed
the
hardcoded-axis-values
branch
from
a287067
to
d9f80b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the axis domain (x-axis for one-dimension spectra and x-axis, y-axis for two-dimension spectra) from the spectra panel preferences. Once it is defined, use Shift + f to zoom out.
close #3024