Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No projection shown if both Bruker and JCAMP 1D present #2750

Open
jliermann opened this issue Nov 13, 2023 · 6 comments · Fixed by #2770
Open

No projection shown if both Bruker and JCAMP 1D present #2750

jliermann opened this issue Nov 13, 2023 · 6 comments · Fixed by #2770
Assignees

Comments

@jliermann
Copy link
Collaborator

If a zipped dataset contains both Bruker and JCAMP 1D spectra, the 2D spectra will have no projections even if all but one 1D spectra are hidden.

Examples:
cyclopentanon_120-92-3.zip
2-picolin_109-06-8a.zip

Remove either the Bruker or JCAMP 1D and it works again.

@evaziegler

@hamed-musallam hamed-musallam self-assigned this Nov 21, 2023
@hamed-musallam
Copy link
Member

initially, in accordance with the default configuration, we prioritize loading the FT spectrum over the FID spectrum when both are available in the same file. However, due to the presence of multiple proton spectra and likewise, for carbon, we haven't specified which spectrum will be utilized for projection in 2D by default so in this case the user should select which proton or carbon for the projection.

Do you have any suggestions?

@lpatiny
Copy link
Member

lpatiny commented Nov 21, 2023

Yes in order to display the trace there should be either only one 1D or there should be one selected 1D (if there are many).

I agree that we often have this issue and this is not intuitive. We could do that if there is more than one 1D spectrum and there is none selected by default we will take the first one.

@hamed-musallam
Copy link
Member

hamed-musallam commented Nov 21, 2023

I'm not sure, is this a general rule, or just if we have 2d samples

@lpatiny
Copy link
Member

lpatiny commented Nov 27, 2023

Just to clarify if no 1D spectrum is selected, we will not select one but only display the first in the list as the 2D trace.

@jliermann
Copy link
Collaborator Author

Thanks for your comments, this is actually two issues, a) that is not intuitive for the user and b) that there is a bug as described by me above.
Do I understand correctly that @hamed-musallam fixed the bug in PR #2770? :-)

@hamed-musallam
Copy link
Member

@jliermann

yes, it is fixed, could you test with https://dev.nmrium.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
3 participants