Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmrium does not read the jcamp source property when there is no data available #1481

Closed
jobo322 opened this issue Apr 18, 2022 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@jobo322
Copy link
Member

jobo322 commented Apr 18, 2022

I am trying to read a nmrium file that contain the jcamp string on source.jcamp property but nmrium throw an error about data.x.length. Could you let me know I having any mistake in the file:

154884.zip

@lpatiny
Copy link
Member

lpatiny commented Apr 18, 2022

@hamed-musallam I think we should allow to have inline jcamp file like we allow jcampURL.

@hamed-musallam
Copy link
Member

@lpatiny

for which property I should check first jcampURL or jcamp?, the exported data should not include both properties

@lpatiny
Copy link
Member

lpatiny commented Apr 19, 2022

We are recovering old data for which we have some assignment and jcamp file. We would like to create a '.nmrium' for those old data.

This means that we will have an inline 'jcamp'.

@lpatiny lpatiny changed the title nmrium does not read the source property when there is not data available nmrium does not read the jcamp source property when there is no data available Apr 19, 2022
@lpatiny lpatiny added the enhancement New feature or request label Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants