Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dependencies #1428

Merged
merged 12 commits into from Apr 5, 2022
Merged

fix: update dependencies #1428

merged 12 commits into from Apr 5, 2022

Conversation

targos
Copy link
Member

@targos targos commented Mar 11, 2022

re-introduce shadow root with style reset

Closes: #1424

@netlify
Copy link

netlify bot commented Mar 11, 2022

Deploy Preview for nmrium ready!

Name Link
🔨 Latest commit f5b5858
🔍 Latest deploy log https://app.netlify.com/sites/nmrium/deploys/624bde56c4f1d10008cc2a6b
😎 Deploy Preview https://deploy-preview-1428--nmrium.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@targos targos marked this pull request as draft March 11, 2022 17:08
@targos
Copy link
Member Author

targos commented Mar 11, 2022

Todo: try to only update analysis-ui-components and not the other dependencies.

@targos
Copy link
Member Author

targos commented Mar 14, 2022

TODO:

  • Try to listen to keyboard events on shadow root. (Peak delete issue)
  • Try to change the value used when the mouse moves. (Range resize issue)

@targos
Copy link
Member Author

targos commented Mar 31, 2022

There is one remaining issue until shadow dom works. It has to do with the Resizable elements (for example ranges, see video below). When you try to resize, it seems the wrong offset is taken into account. I'm not surprised it doesn't work, because the layerX property is not standard. We should use another one instead.

@hamed-musallam could you please have a look ? Don't forget to npm ci on the branch to have the latest deps.

Screen.Recording.2022-03-31.at.15.38.18.mov

@hamed-musallam
Copy link
Member

thank you @targos , i will take a look.

@hamed-musallam
Copy link
Member

hamed-musallam commented Apr 4, 2022

@targos
please could you take a look at why the test and deploy preview always failed

@targos
Copy link
Member Author

targos commented Apr 4, 2022

@hamed-musallam does npm run build-no-minify work without crashing on your computer?

@hamed-musallam
Copy link
Member

hamed-musallam commented Apr 4, 2022

@targos
yes, npm run build-no-minify works without crashing on my computer

@hamed-musallam
Copy link
Member

@targos
export as SVG not working anymore
image

@targos targos marked this pull request as ready for review April 4, 2022 13:54
@targos
Copy link
Member Author

targos commented Apr 4, 2022

@hamed-musallam I fixed the "export as" feature.

For the build, I guess that some updated dependency makes it take more memory than before and github builders don't have enough memory. I need to investigate more.

@targos
Copy link
Member Author

targos commented Apr 4, 2022

@hamed-musallam The build is fixed. Can I merge now?

@hamed-musallam
Copy link
Member

hamed-musallam commented Apr 4, 2022

@targos
i need to do one more thing before we merge, can we delay the merger for tomorrow, we still need to change one more place to use the new resizer

@hamed-musallam
Copy link
Member

hamed-musallam commented Apr 5, 2022

@targos
could you please merge the PR if you do not have any comments, I completed my work on this branch

@targos targos merged commit 21ffc50 into master Apr 5, 2022
@targos targos deleted the update-shadow branch April 5, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some buttons look strange when importing NMRium component
2 participants