-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update dependencies #1428
fix: update dependencies #1428
Conversation
✅ Deploy Preview for nmrium ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Todo: try to only update analysis-ui-components and not the other dependencies. |
TODO:
|
Re-introduce shadow root with style reset. Closes: #1424
There is one remaining issue until shadow dom works. It has to do with the Resizable elements (for example ranges, see video below). When you try to resize, it seems the wrong offset is taken into account. I'm not surprised it doesn't work, because the @hamed-musallam could you please have a look ? Don't forget to Screen.Recording.2022-03-31.at.15.38.18.mov |
thank you @targos , i will take a look. |
@targos |
@hamed-musallam does |
@targos |
@targos |
@hamed-musallam I fixed the "export as" feature. For the build, I guess that some updated dependency makes it take more memory than before and github builders don't have enough memory. I need to investigate more. |
@hamed-musallam The build is fixed. Can I merge now? |
@targos |
@targos |
re-introduce shadow root with style reset
Closes: #1424