Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the dom to not allow the "Structures" panel to expand #1361

Merged
merged 4 commits into from Feb 3, 2022

Conversation

Sebastien-Ahkrin
Copy link
Collaborator

Closes: #1341

@lpatiny Actually i have that (with this fix)
Capture d’écran 2022-02-01 à 16 25 38

Do this works with your example ?

@netlify
Copy link

netlify bot commented Feb 1, 2022

✔️ Deploy Preview for nmrium ready!

🔨 Explore the source changes: b7bf935

🔍 Inspect the deploy log: https://app.netlify.com/sites/nmrium/deploys/61fbe3cd21f98f0007e07f42

😎 Browse the preview: https://deploy-preview-1361--nmrium.netlify.app/

@targos targos requested a review from lpatiny February 2, 2022 08:35
@lpatiny
Copy link
Member

lpatiny commented Feb 2, 2022

Seems to me it is not fixed.

Just draw a long vertical molecule and put a O in the bottom.

2022-02-02 12 21 01

@targos
Copy link
Member

targos commented Feb 2, 2022

The problem is that the size of the div that contains the molecule is 100% of its parent, but it shouldn't because there is a sibling element (with the molecular formula).

@Sebastien-Ahkrin
Copy link
Collaborator Author

Actually, i can get something like that:
Capture d’écran 2022-02-03 à 11 39 47

:)

@targos
Copy link
Member

targos commented Feb 3, 2022

Nice! Now the size is correct by default, but there is still an issue when the container becomes smaller (for example if you open other panels).

image

Usually this is fixed by putting min-height: 0 on the right flex elements.

@targos
Copy link
Member

targos commented Feb 3, 2022

See here. You need min-height: 0 on two more elements and it works:
image

@targos targos merged commit 59df13f into master Feb 3, 2022
@targos targos deleted the fix-structures-too-big branch February 3, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Part of the structure may be hidden under the title of next tab
3 participants