feat: prevent crash with multiplet analysis #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for nmrium ready! 🔨 Explore the source changes: 48fa2cd 🔍 Inspect the deploy log: https://app.netlify.com/sites/nmrium/deploys/620265b975d4e300085e273c 😎 Browse the preview: https://deploy-preview-1356--nmrium.netlify.app/ |
targos
reviewed
Feb 3, 2022
Sebastien-Ahkrin
force-pushed
the
multiplet
branch
from
9095952
to
a6cb8a1
Compare
|
@stropitek Please spend some time with @Sebastien-Ahkrin to refactor this so that no side-effects happen in the reducer or in the |
stropitek
reviewed
Feb 7, 2022
stropitek
reviewed
Feb 7, 2022
|
Please fix the lintint issues |
stropitek
reviewed
Feb 8, 2022
stropitek
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1328