Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improvements correlation table, i.e. allow movement of links #1268

Merged
merged 36 commits into from
Nov 5, 2021
Merged

feat: improvements correlation table, i.e. allow movement of links #1268

merged 36 commits into from
Nov 5, 2021

Conversation

michaelwenk
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Oct 15, 2021

✔️ Deploy Preview for nmrium ready!

🔨 Explore the source changes: b071fd9

🔍 Inspect the deploy log: https://app.netlify.com/sites/nmrium/deploys/6185401ff9b65200073c7a21

😎 Browse the preview: https://deploy-preview-1268--nmrium.netlify.app/

@hamed-musallam
Copy link
Member

@michaelwenk

These comments it's related to the UI and not to the core of your work,

1- validate the input so it's not accept empty value
image
2- remove Horizontal and vertical scroll
image
3-remove horizontal lines from the cell seem that they appear only when hover
image
4- align and validate input fields and prevent accepting empty value
image
5- Prevent the table from expanding when we have fewer rows, as you can see the height of the rows become bigger when we have fewer rows, you have to take to not broke the scroll

@hamed-musallam hamed-musallam merged commit 2410e65 into cheminfo:master Nov 5, 2021
@michaelwenk michaelwenk deleted the improvement-correlation-table-2 branch November 8, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants