Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening panel load and display the database #1254

Closed
lpatiny opened this issue Oct 3, 2021 · 10 comments
Closed

Opening panel load and display the database #1254

lpatiny opened this issue Oct 3, 2021 · 10 comments
Assignees
Projects

Comments

@lpatiny
Copy link
Member

lpatiny commented Oct 3, 2021

When opening the Database panel, load the database:

(call getDatabase in the last version or nmr-processing)

(we should not make the call before opening the first time this panel)

Please plan directly that there may be many databases !!!

So in the state the database should be an object and this default database could have as key Solvent.

I would directly plan a more complex structure like (not sure about the names ...)

databases: {
  data: {
     solvent: { // when we load a database we should specify a name
        description: 'Solvent database',
        value: getReference()
    }
  }
}
@lpatiny lpatiny added this to To do in Database via automation Oct 3, 2021
@hamed-musallam
Copy link
Member

@lpatiny
I can not find getDatabase function from the last published nmr-processing, Does it exported?

@targos
Copy link
Member

targos commented Oct 4, 2021

Note that it should be "solvent".
Solvant is French

@hamed-musallam hamed-musallam moved this from To do to In progress in Database Oct 4, 2021
@lpatiny
Copy link
Member Author

lpatiny commented Oct 4, 2021

Note that it should be "solvent". Solvant is French

Thanks I corrected my issue description.

@lpatiny
Copy link
Member Author

lpatiny commented Oct 4, 2021

@lpatiny I can not find getDatabase function from the last published nmr-processing, Does it exported?

Yes it is not yet published. Please ask to @jobo322

@hamed-musallam
Copy link
Member

hamed-musallam commented Oct 6, 2021

@lpatiny
I confused about the structure that you suggested, how it linked with the 2 solvents database is it going to be under data object as I can see one for proton and one for carbon, is I suppose to combine both or do we need to check if it's carbon then display the carbon data and the same for proton

@hamed-musallam
Copy link
Member

@lpatiny
Also what I see solvent, names, and ranges but I can not find meta and smiles, what I have to do with it?

@hamed-musallam
Copy link
Member

hamed-musallam commented Oct 6, 2021

@lpatiny
why did it supposed to be in the main state if we only need it for display in the table because in any way it looks like constants and we do not make any action on the data?

@lpatiny
Copy link
Member Author

lpatiny commented Oct 6, 2021

for now you can join those 2 database:

database = [...carbonImpurities, ...protonImpurities]

You are right there are currently no smiles. I will add some.

I don't remember to have say it should be main state. Local state should be suitable for this project.

@hamed-musallam
Copy link
Member

@lpatiny
you request to have two dropdown lists the first one is for the database for now we have only solvent and the other works as a filter by solvents for know I see that we have one common value is it going to be changed? or just we can have an input field that we can search inside all the values not for solvent only

@lpatiny
Copy link
Member Author

lpatiny commented Oct 6, 2021

We will need to have 3 way to filter:

  • based on the nucleus, this depends on the currently selected spectrum, so no need to add a dropdown menu, it should be automatic
  • based on the solvant, this depends on the currently selected spectrum but could be overiden
  • all the other fields: this is one filed and it will search everywhere using smart-array-filter

Database automation moved this from In progress to Done Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants