Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary table crashes when editing number of protons #1112

Closed
nes-cgn opened this issue Jun 1, 2021 · 3 comments
Closed

Summary table crashes when editing number of protons #1112

nes-cgn opened this issue Jun 1, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@nes-cgn
Copy link
Collaborator

nes-cgn commented Jun 1, 2021

In the following example, assignment was possible but once I tried to complete the entries in the summary table, the example crashed:
https://cdn.nmrium.org/v0.12.0/index.html?sampleURL=https://cheminfo.github.io/nmr-dataset1/data/2D-140-67-0-solved.json#/

when I intend to add the number of protons in the fields marked with arrows, the page crashes:
corrtab_ex7_crash

@nes-cgn nes-cgn added the bug Something isn't working label Jun 1, 2021
@hamed-musallam
Copy link
Member

@nes-cgn
I dug into the problem and I found it is may be related to the library that developed by Michael, I will contact him and work together to solve it as soon as possible.

image

@nes-cgn
Copy link
Collaborator Author

nes-cgn commented Jun 1, 2021 via email

@michaelwenk
Copy link
Member

@nes-cgn I did a pull request for this. After the merge by Hamed, it should work again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants