feat: improve default values for auto phase. close #1093 #1099
Conversation
| magnitudeMode: false, | ||
| minRegSize: 30, | ||
| maxDistanceToJoin: 256, | ||
| minRegSize: 10, |
There was a problem hiding this comment.
Could you change the variable name ? Is this minResionSize ?
There was a problem hiding this comment.
So, we will need to wait for the new release of ml-spectra-processing
| minRegSize: 30, | ||
| maxDistanceToJoin: 256, | ||
| minRegSize: 10, | ||
| maxDistanceToJoin: 128, |
There was a problem hiding this comment.
Should this option not be dependant from the number of points in the spectrum ? We have spectra with 1k points and some with 256k points.
There was a problem hiding this comment.
It should be tested because I believe it does not relate with the resolution of the spectrum, it is closer to how much noise has the spectrum, but I put a bigger cutoff for noise, I think we could test with those parameters to check if it works for most cases.
| minRegSize: 10, | ||
| maxDistanceToJoin: 128, | ||
| magnitudeMode: true, | ||
| factorNoise: 5, | ||
| }; | ||
|
|
||
| export function apply(datum1D, options = {}) { | ||
| if (!isApplicable(datum1D)) { | ||
| throw new Error('phaseCorrection not applicable on this data'); | ||
| } | ||
| options = Object.assign({}, defaultOptions, options); |
There was a problem hiding this comment.
Please use the new syntax
options = {...defaultOptions, ...options}
There was a problem hiding this comment.
you can also directly pass the spread to the function call: reimAutoPhaseCorrection(datum1D.data, {...defaultOptions, ...options})
There was a problem hiding this comment.
you are just right, options is used just this once.
No description provided.