Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always use the zones for polynomial baseline correction. #1092

Merged
merged 2 commits into from May 18, 2021
Merged

fix: always use the zones for polynomial baseline correction. #1092

merged 2 commits into from May 18, 2021

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented May 17, 2021

close #1073

@jobo322 jobo322 requested a review from lpatiny May 17, 2021 17:11
lpatiny
lpatiny reviewed May 17, 2021
View reviewed changes
Copy link
Member

@lpatiny lpatiny left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check what happens when there is no zones selected (I guess it is ok) ?

How do you send the options for the polynomial degree ? Seems there should be options.regressionOptions

@jobo322 jobo322 closed this May 17, 2021
@jobo322 jobo322 reopened this May 17, 2021
@lpatiny lpatiny merged commit cf7fa99 into master May 18, 2021
@lpatiny lpatiny deleted the fixBaselineCorrection branch May 18, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpatiny lpatiny lpatiny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polynomial baseline correction seems weird
2 participants
@jobo322 @lpatiny