Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update dependencies nmr-parser and ml-spectra-processing #1042

Merged
merged 5 commits into from May 12, 2021
Merged

feat: update dependencies nmr-parser and ml-spectra-processing #1042

merged 5 commits into from May 12, 2021

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented May 12, 2021

No description provided.

@hamed-musallam
Copy link
Member

@jobo322

  • please update prettier, run " npm ci ",
  • check if prettier is ok "npm run prettier".
  • to fix format "npm run prettier-write"

@jobo322 jobo322 force-pushed the fixing branch 2 times, most recently from 06bdcf0 to e8ef789 Compare May 12, 2021 13:08
@hamed-musallam
Copy link
Member

@jobo322
can you fix prettier and check the format every time you make a commit

@targos
Copy link
Member

targos commented May 12, 2021

I suggest you setup the Prettier VSCode extension to format the code on save and avoid having to do it everytime afterwards.

@hamed-musallam hamed-musallam merged commit d443fd7 into master May 12, 2021
@hamed-musallam hamed-musallam deleted the fixing branch May 12, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jobo322 @hamed-musallam @targos