Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change react-refresh/only-export-components to error #38

Open
stropitek opened this issue Apr 11, 2024 · 2 comments
Open

Change react-refresh/only-export-components to error #38

stropitek opened this issue Apr 11, 2024 · 2 comments
Assignees

Comments

@stropitek
Copy link
Contributor

I'd be in favour of making this an error because we don't pay too much attention to warnings in PRs and after some time we end up with a lot of those and they make it harder to pay attention to more important warnings like TODOs.

It's a bit tedious if there are many but straightforward to fix.

WDYT @cheminfo/collaborators ?

@tpoisseau
Copy link
Contributor

Some times, this rule can be annoying to apply (like a constant used by a component and exported). But I agree, applying this rule leads to a better developer experience in long term. And do not apply it, can lead to weird bug during dev.

So go switch this rule to error.

@targos
Copy link
Member

targos commented Apr 11, 2024

When I added this rule the intention was to switch to error at some point while allowing to incrementally fix it first. If people don't care about it and tend to introduce more warnings then sure, we can switch to error right now.

@stropitek stropitek self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants