Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sigact dump/restore code into separate file #336

Closed
xemul opened this issue Jun 29, 2017 · 5 comments · Fixed by #2361
Closed

Move sigact dump/restore code into separate file #336

xemul opened this issue Jun 29, 2017 · 5 comments · Fixed by #2361
Assignees
@prakritigoyal19
Labels
enhancement no-auto-close Don't auto-close as a stale issue

Comments

@xemul
Copy link
Member

xemul commented Jun 29, 2017

In the parasite-syscall.c file there's a function parasite_dump_sigacts_seized(). In the cr-restore.c file there's a prepare_sigactions() call (and whatever it calls).

Both are better to be moved into a .c file in the criu/ dir.
@prakritigoyal19
Copy link
Member

@xemul Hi! I would like to work on this issue. Can this be assigned to me please?

@xemul xemul assigned xemul and prakritigoyal19 and unassigned xemul Mar 13, 2020
@xemul
Copy link
Member Author

xemul commented Mar 13, 2020

Done

@prakritigoyal19
Copy link
Member

Hey, I have mailed my patches to the CRIU mailing list. Please let me know if I should make any changes.

The repo link for the same is https://github.com/prakritigoyal19/criu/tree/sigactions.

Thank You!

@rakki-18 rakki-18 mentioned this issue Dec 12, 2020
Closed
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@avagin avagin removed the stale-issue label Mar 2, 2021
@github-actions
Copy link

github-actions bot commented Apr 4, 2021

A friendly reminder that this issue had no activity for 30 days.

@github-actions github-actions bot closed this as completed Apr 4, 2022
@mihalicyn mihalicyn added no-auto-close Don't auto-close as a stale issue and removed stale-issue labels Mar 13, 2023
@mihalicyn mihalicyn reopened this Mar 13, 2023
@arnavbhatt288 arnavbhatt288 mentioned this issue Mar 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prakritigoyal19 prakritigoyal19

Labels
enhancement no-auto-close Don't auto-close as a stale issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

criu: move sigact dump/restore code into sigact.c arnavbhatt288/criu
4 participants
@mihalicyn @avagin @xemul @prakritigoyal19