Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with Apple Pay and version 4.3.3 of Frames and 2.0.3 of Risk SDKs #526

Open
kevinpalser opened this issue Apr 9, 2024 · 16 comments
Open
Assignees

Comments

@kevinpalser
Copy link

Describe the bug
We updated from 4.3.2 to 4.3.3. No problems previously. With 4.3.3 as soon as the Apple Pay biometric face matching step finished there is a crash. Looking at the crash log it took us to a log function in the Risk module being the last function call.

To Reproduce
Steps to reproduce the behavior:

  1. Have custom integration, i.e not using the UI flow available from the SDK and calling the key functions directly.
  2. Proceed to biometric confirmation step of Apple Pay and the charge.

Expected behavior
Not to crash at the risk logging step.

Screenshots
Screenshot after tapping on the crash log to where the problem occurs.
Frames crash

Smartphone (please complete the following information):

  • Device: iPhone 14 Pro Max
  • OS: iOS 17.4.1

Additional context
The transaction when crashing went through to our server. This suggests the subsequent logging step is at fault. Seems to be replicable in that it keeps crashing. We reverted to Frames 4.3.2 & Risk 2.0.1 and the crash does not occur.

@okhan-okbay-cko
Copy link
Contributor

Hey @kevinpalser, can you please share the crash log that is produced in an isolated project?

Feel free to share it over here after you strip off the confidential/private information.

Currently, we couldn't reproduce the issue.

@kevinpalser
Copy link
Author

Hey @kevinpalser, can you please share the crash log that is produced in an isolated project?

Feel free to share it over here after you strip off the confidential/private information.

Currently, we couldn't reproduce the issue.

Here is the crash report with semi confidential info marked as [redacted]

2024-04-09_07-17-55.8156_+0100-16266a2d24b31400d7285b9d5fa32e7f08de0498.txt

@okhan-okbay-cko
Copy link
Contributor

Hey @kevinpalser, thanks for raising this and thanks for helping with additional data.

Unfortunately, I can't rule out an exact reason for it now. Our sample apps all work as expected. Also, if I have a look at the diff in between Risk SDK's 2.0.2 and 2.0.3 versions, I can't see any culprits.

If you'd like to help us further and isolate the issue in a sample project, please feel free.

Also, can you please share your Xcode version?

@kevinpalser
Copy link
Author

kevinpalser commented Apr 10, 2024

Unfortunately, I can't rule out an exact reason for it now. Our sample apps all work as expected. Also, if I have a look at the diff in between Risk SDK's 2.0.2 and 2.0.3 versions, I can't see any culprits.

Pitty - thanks for your efforts.

If you'd like to help us further and isolate the issue in a sample project, please feel free.

It would need time to pull out and make a mini project. If we can allocate the time, we'll try.

Also, can you please share your Xcode version?

Xcode 15.2 because of waiting on a resolution with another framework. I could test on Xcode 15.3.

@hai-ijji
Copy link

I'm pretty sure the Risk SDK 2.0.3 caused the issue. It crashed randomly for me, not only with Apple Pay but also with the new card form using Frames 4.3.3. I had to downgrade to Frames 4.3.2 and Risk 2.0.1 to fix the crash.
Btw, I could never reproduce it in sandbox mode. It only crashed in Live mode, which we could only see if testing via TestFlight.

@kevinpalser
Copy link
Author

Hi @hai-ijji

It only crashed in Live mode, which we could only see if testing via TestFlight.

Same situation for us: live mode and TestFlight. Are you still using Frames 4.3.2 and Risk 2.0.1? We have not tried 4.3.4 because the change log reports minor version bump with no public facing changes.

@hai-ijji
Copy link

@kevinpalser Yeah, I think using Frames 4.3.2 and Risk 2.0.1 is fine for now. The changes in new Frames version were not significant and the changes in Risk SDK mostly for logs.

@okhan-okbay-cko
Copy link
Contributor

hey, thanks for reporting and sorry for the inconvenience!

Can you please give version 4.3.5 a go if possible? @hai-ijji @kevinpalser

@kevinpalser
Copy link
Author

@okhan-okbay-cko I'll try and make time tomorrow to test the 4.3.5 branch. Thanks.

@okhan-okbay-cko
Copy link
Contributor

Thank you! You can use the tag directly if you prefer.

@kevinpalser
Copy link
Author

kevinpalser commented May 1, 2024

@okhan-okbay-cko @hai-ijji
I tested with the unreleased test branch with a live Apple Pay transaction using a TestFlight release and there was no crash.
Captura de pantalla 2024-05-01 a les 16 48 33

Captura de pantalla 2024-05-01 a les 16 50 21

@okhan-okbay-cko
Copy link
Contributor

I'll be closing this issue. Please feel free to re-open or create a new one if you face with the same crash.

@woolstrand
Copy link

This still happens for us. 4.3.5 crashed in live environment immedately after successful face recognition. Attaching crash log which might probably help.
2024-05-08_15-29-40.8635_+0200-9b1d793c0dd6bf52362a832dd694d8c233b2b03b.crash.txt

@kevinpalser
Copy link
Author

@okhan-okbay-cko unfortunately like @woolstrand we also had a couple of crashes yesterday recorded yesterday with 4.3.5 and shall revert back to 4.3.2. The 4.3.5 crash frequency is less than 4.3.3/4 but still less stable than 4.3.2.

@Prakaship78
Copy link

Prakaship78 commented May 22, 2024

I am still able to face this crash issue in 4.3.5 version on sandbox. Downgrading to 4.3.2 is working fine .
I am not using any face recognition , as soon as the 3DSWebViewController is presented app is getting crashed .
image (6)

@jheng-hao-lin-cko
Copy link

Hi everyone, our apologies for causing all inconvenience. We are aware of this issue and actively working on it. Will keep you posted on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants