Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File/image uploader: drag and drop is missing a pointer that indicates it is doing anything #325

Closed
robbieaverill opened this issue Oct 14, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@robbieaverill
Copy link
Contributor

When you drag and drop an image into say the product edit screen, it has a "default" pointer cursor. We should use "move" or something to indicate that you're actually doing something.

@robbieaverill robbieaverill added the bug Something isn't working label Oct 14, 2020
@kvisca kvisca assigned kvisca and unassigned kvisca Oct 16, 2020
@jaepass jaepass self-assigned this Oct 30, 2020
@jaepass
Copy link
Contributor

jaepass commented Oct 30, 2020

did some research into this and quite a few logged issues saying this might not be possible. react-dnd/react-dnd#325 (comment). im sure there's still some kind of work around. i've tried hooking into the drag events while dragging operation is happening and still not working:

    this.dropzone.on('dragover', this.handleDragover);

    handleDragover(e) {
      e.dataTransfer.effectAllowed = 'move';
    },

@robbieaverill
Copy link
Contributor Author

No problem, it was a nice to have anyway. Thank you for looking into it.

@collab-with-tushar-raj
Copy link

Why this ticket is closed ? Have we already got the solution ?

@robbieaverill
Copy link
Contributor Author

Hi @Tush2890, we closed the ticket for the reasons mentioned above - we've decided not to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants