Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database container port inconsistency #2772

Open
mhauru opened this issue Apr 24, 2024 · 1 comment
Open

Database container port inconsistency #2772

mhauru opened this issue Apr 24, 2024 · 1 comment

Comments

@mhauru
Copy link
Contributor

mhauru commented Apr 24, 2024

The main Makefile and a couple of pages in the documentation assume that the database Docker container is run so that the PostgreSQL port is 5434:
https://github.com/search?q=repo%3Achaoss%2Faugur%205434&type=code

However, some other places use the default port 5432. Here are a few files doing that, I'm not sure I found all of the cases:
https://github.com/chaoss/augur/blob/a786ac5a506ffac31931f40c2a58056b7c1f073c/scripts/control/refresh-matviews.sh
https://github.com/chaoss/augur/blob/a786ac5a506ffac31931f40c2a58056b7c1f073c/docs/new-install.md

- "127.0.0.1:${AUGUR_DB_PORT:-5432}:5432"

@click.option("--port", default="5432")

@GaryPWhite
Copy link
Contributor

I think this is an artifact of times gone by -- augur_database is not the same as the postgres container recently included in the compose file.

some of the blame shows this was done literally 4 years ago -- maybe the project has pivoted since then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants