Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Typo in current version #2716

Closed
wants to merge 1 commit into from
Closed

Conversation

Manasvie
Copy link

Description

  • Fixed the typo in the column current_version which was previously spelled as 'current_verion'.

This PR fixes #2662

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Manasvi Bagherwal <manasvi373bagherwal@gmail.com>

Signed-off-by: Manasvie <manasvi373bagherwal@gmail.com>
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to handle schema changes in ORM sequence, and account for column name change procedures.

@@ -127,14 +127,14 @@ def add_materialized_views_15(upgrade=True):
a.repo_name,
b.name,
b.requirement,
b.current_verion,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way to change column names is to add a new alembic script in this same directory, and ensure that it does the column renaming correctly. Unfortunately this involves creating a temporary table, loading existing data, recreating the repo_deps_libyear table and loading the data back from the temp table.

@sgoggins sgoggins marked this pull request as draft February 28, 2024 16:50
@sgoggins sgoggins closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repo_deps_libyear column name misspelled
2 participants