Update to Angular 9

[Enngage]

Hey,

as title suggest, can you update peer deps for Angular 9? :)

[chaodyz]

Hey,
I finished the update, everything works fine for projects running the latest Angular. However there is a typescript compatible issue,
storybookjs/storybook#9463
So that means in order to use the new build, users would have to upgrade to typescript 3.7, which is not compatible to Angular 8 and below
Therefore, I'm holding off this upgrade for now till I find a good solution, if you have any suggestion, please let me know!

[Enngage]

Hi, I think you should update this library. Users using older Angular version can use older versions of your package. Angular 8 is already out of active support and its LTS ends quite soon - https://angular.io/guide/releases

Is there really a need to hold on this update? Do old users using angular 8 need to use new versions of this library for angular 9? No matter how I look at it it doesn't make much sense to postpone update.

[chaodyz]

Hi Enngage,

Thanks for your input, I have updated the dependencies, if there is not issue on your side, I will close this thread.

Regards,
Di

[Enngage]

Yeah, we can close this thread. Thanks!

[Enngage]

Hi,

sorry, this is not resolved. You haven't updated peer dependencies in your lib here https://github.com/DiZhou92/ngx-line-truncation/blob/master/projects/line-truncation-lib/package.json#L24

This is still giving peer dependency warnings when using with Angular 9

[chaodyz]

Oh sorry about that, will get it updated soon. Thank you sir. Regards, Di

…

On Wed, May 13, 2020 at 3:59 AM Richard Sustek ***@***.***> wrote: Reopened #22 <#22>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#22 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCTI64VPUY3TPJB6UP7TBTRRJHM7ANCNFSM4LNE47DQ> .

[chaodyz]

Hi Enngage, I just got peer dependency update, let me know if that works for you. Thanks!

[Enngage]

Hi @DiZhou92 ,

Thank you, but it still isn't quite right :)

You cannot combine both ^ and ~ in peer dependencies. See https://stackoverflow.com/questions/22343224/whats-the-difference-between-tilde-and-caret-in-package-json

You should actually define peer dependencies as:

"@angular/common": "~9.0.0",
 "@angular/core": "~9.0.0"

So that anyone using Angular 9 can install and use your library without unnecessary warning. You are not depending on any specific features released in e.g. 9.1.7 version, so you don't need to specify it.

[chaodyz]

Hey i made mistake there, a bit dumb 😅 my apology, was looking for the ~ ^ definition and forget to remove the extra one

[chaodyz]

did an update with ^ because i think its ok to be compatible with any V9, let me know!

[Enngage]

Its ok now, thank you :)

…

On Thu, 14 May 2020 at 16:17, Di Zhou ***@***.***> wrote: did an update with ^ because i think its ok to be compatible with any V9 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#22 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABWOQR6OHXW5JR26UZQ5O3DRRP4PDANCNFSM4LNE47DQ> .