Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin author not shown in napari-hub #1310

Closed
marcel-goldschen-ohm opened this issue Apr 12, 2024 · 2 comments
Closed

Plugin author not shown in napari-hub #1310

marcel-goldschen-ohm opened this issue Apr 12, 2024 · 2 comments
Assignees
Labels
bug Something isn't working P3 Low Priority

Comments

@marcel-goldschen-ohm
Copy link

Description

The author name is not shown for the plugin napari-cosmos-ts despite the author name being correctly identified in PyPI.

The author metadata is defined in pyproject.toml as (replace "..." with actual name and email):

[project]
authors = [
    {name = "...", email = "..."},
]

Expected Results

I expected napari-hub to find the author name given that it is identified on PyPI.

It seems silly to have to include another config file in the repo just for this metadata, but if that is the only solution, can someone please give me an example of what such a file should look like.

@marcel-goldschen-ohm marcel-goldschen-ohm added the bug Something isn't working label Apr 12, 2024
@manasaV3
Copy link
Collaborator

Hi there,
Digging into this, I believe the reason for the author name not making it to the site is because of how the data from pyproject.toml is parsed.

When both email and name are provided, the value goes in Author-email or Maintainer-email as appropriate, with the format {name} <{email}>.

ref: https://packaging.python.org/en/latest/specifications/pyproject-toml/#authors-maintainers

This leaves the author values as None, and we currently don't surface any author details for cases where the author name is None.

Until this bug is prioritized to be fixed on our end, a quick way to fix this would be to make the name and email into different entries as follows:

[project]
authors = [
    {name = "..."}, 
    {email = "..."},
]

Sorry for the inconvenience.

@manasaV3 manasaV3 added the P3 Low Priority label May 30, 2024
@marcel-goldschen-ohm
Copy link
Author

Thanks @manasaV3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3 Low Priority
Projects
None yet
Development

No branches or pull requests

2 participants