Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion on delegating responsibility for composition to TextField #977

Closed
quino0627 opened this issue Nov 9, 2022 · 0 comments · Fixed by #1082
Closed

Discussion on delegating responsibility for composition to TextField #977

quino0627 opened this issue Nov 9, 2022 · 0 comments · Fixed by #1082
Assignees
@Tanney-102
Labels
enhancement Issues or PR related to making existing features better

Comments

@quino0627
Copy link
Contributor

quino0627 commented Nov 9, 2022 •
edited

Description

많은 언어들이 컴포지션 과정에서 별도의 IME 입력창을 띄웁니다. (대표적으로 일본어가 그렇습니다)
이를 bezier TextField, TextArea에서 올바르게 지원하도록 변경하는 것에 대한 논의를 진행합니다.

Reasons for suggestion

  • 특정 언어에서만 발생하는것이 아닌, 다수 언어에서 발생하는 현상으로 Design System에서 지원할 지에 대한 논의는 필요합니다.

Proposed solution

Desk의 TextFieldWithComposition 참조
아래 React repository의 이슈 참조

References

https://github.dev/primer/react 의 useIgnoreKeyboardActionsWhileComposing.ts 참조
facebook/react#3926
@quino0627 quino0627 added status:need triage Issue or PR that need triage attention suggestion and removed status:need triage Issue or PR that need triage attention labels Nov 9, 2022
@sungik-choi sungik-choi added enhancement Issues or PR related to making existing features better component labels Nov 9, 2022
@sungik-choi sungik-choi changed the title Discussion on delegating responsibility for composition to TextField Discussion on delegating responsibility for composition to TextField Nov 9, 2022
@Tanney-102 Tanney-102 mentioned this issue Dec 21, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tanney-102 Tanney-102

Labels
enhancement Issues or PR related to making existing features better
Projects
Bezier React
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add handlers for composition on Inputs Tanney-102/bezier-react
3 participants
@quino0627 @Tanney-102 @sungik-choi