ErrorException (E_NOTICE) when user with master role request /home

[stardigits]

Describe the bug
ErrorException (E_NOTICE) happen when user with master role request /home

To Reproduce
Steps to reproduce the behavior:

1. Login as master
2. Request using url /home

Expected behavior
It should redirect to /masters (master homepage)

Screenshots
ErrorException (E_NOTICE)
Trying to get property 'id' of non-object

\app\Http\Controllers\HomeController.php
* Create a new controller instance.
*
* @return void
*/
public function __construct()
{
$this->middleware('auth');
}

/**
 * Show the application dashboard.
 *
 * @return \Illuminate\Http\Response
 */
public function index()
{
    $minutes = 1440;// 24 hours = 1440 minutes
    $school_id = \Auth::user()->school->id;

[changeweb]

Please see Auth\LoginController.php -> public function redirectTo(){}

[qq690712575]

I also met this problem for the first time.

[changeweb]

@qq690712575 @stardigits Can you please share any screenshots with error messages?

[stardigits]

@changeweb, Error description is clear. This error happens when 'master' entering url /home.
I did modify the HomeController.php as follows:

    public function index()
    {
      if (\Auth::user()->role != 'master') {
        $minutes = 1440;// 24 hours = 1440 minutes
        /* codes for non master users */
      } else {
        return redirect('/masters');
      }
    }

It's resolved.

[changeweb]

@stardigits It would be great if you make a PR.

[vyrral]

what function is used to promote student from one class/section/academic year to another, cant seem to find it