Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C2: Add migration for links/tools on homepage from C1 to C2 #5088

Open
ywarnier opened this issue Jan 15, 2024 · 7 comments · May be fixed by #5310
Open

C2: Add migration for links/tools on homepage from C1 to C2 #5088

ywarnier opened this issue Jan 15, 2024 · 7 comments · May be fixed by #5310

Comments

@ywarnier
Copy link
Member

ywarnier commented Jan 15, 2024

The migration currently does not deal with links (and other resources) that were added on the courses' homepages in C1 (to the c_tool table).
These should now be transformed into "shortcuts" in C2.

Linked to #5073

@ywarnier
Copy link
Member Author

ywarnier commented Mar 4, 2024

I'm changing the assignee for approval here, because @NicoDucou will be going through a comprehensive migration soon.
This is just a note that there should be a check that links and other resources (like LPs) marked as "show on course homepage" should now be converted to shortcuts when migrated from 1.11 to 2.0.

@NicoDucou
Copy link
Member

The link do not appear for the moment on the homepage. It can be checked after migration on this course : https://.........../course/154/home There should be a LP on the homepage.

@AngelFQC
Copy link
Member

Migration is done for learnpaths and learnpath categories. For links, it was already done.

However, on the functionality side of showing the course home, is needed to filter the learnpath and lp category shortcuts to show then according to the prerequisites between learnpaths

AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 29, 2024
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 29, 2024
@AngelFQC
Copy link
Member

However, on the functionality side of showing the course home, is needed to filter the learnpath and lp category shortcuts to show then according to the prerequisites between learnpaths

Related issue #5357

@NicoDucou
Copy link
Member

Hola Angel,
Estuve revisando este issue para validarla pero no me ha funcionado en la migracion de la semana pasada.
Revisando me doy cuenta que no se hizo merge al PR #5310
Entonces por eso no estaba incluido en la migracion que hice.
Veo que ahora hay conflictos y no se puede hacer merge.
Podrias revisarlo y hacer el merge a menos que tengas una razon por no hacer lo ?

@ywarnier
Copy link
Member Author

@NicoDucou acabo de mandar un commit que arregla el conflicto menor. Estaba revisando los PRs, así que lo hice de paso.

AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Apr 23, 2024
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Apr 23, 2024
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Apr 23, 2024
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Apr 23, 2024
@AngelFQC
Copy link
Member

I've rebased with master to re-resolve the conflict and change the calls to container and entity manager (post symfony 6 changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment