Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc Argument order #98

Open
srush opened this issue Aug 10, 2022 · 1 comment
Open

Arc Argument order #98

srush opened this issue Aug 10, 2022 · 1 comment

Comments

@srush
Copy link
Collaborator

srush commented Aug 10, 2022

I don't know how important this is, but should the arc function use the same direction (either clockwise or counterclockwise) irrespective of its arguments? For example,

dia = cat(
    [
        arc(1, 0, 90).show_origin(),
        arc(1, 90, 0).show_origin(),
        arc(1, 90, 360).show_origin(),
    ],
    unit_x,
    sep=0.5
)

produces
test_arc
but maybe the second arc should be the same as the third one?

Originally posted by @danoneata in #96 (comment)

@danoneata
Copy link
Collaborator

I was thinking about this; maybe a clearer alternative would be for arc to just mirror ArcSegment's constructor? That is, specify an arc by its radius, starting angle and a difference (delta) angle (instead of the ending angle).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants