Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review log levels of some statements #248

Open
tahini opened this issue Aug 4, 2023 · 0 comments
Open

review log levels of some statements #248

tahini opened this issue Aug 4, 2023 · 0 comments

Comments

@tahini
Copy link
Collaborator

tahini commented Aug 4, 2023

When logging info, we have a lot of calculating alternative x from a total of y ..., but nothing else.

We should revisit our log statements to allow high level information in info level, then increase for log statements for debug and trace.

tahini added a commit to tahini/trRouting that referenced this issue Aug 7, 2023
Part of chairemobilite#248

The alternatives calculation statements are set to 'debug' instead of
'info'.

The log statement at the beginning and end of the v2/* routes are set to
'info' and parameters are removed, spdlog will associate a timestamp with
the log, so no need to display the application's time.

If a catchall exception occurs, the log level is 'error'.

TODO
Cleanup the 'debug' statements and set a few as 'trace'
greenscientist pushed a commit that referenced this issue Aug 29, 2023
Part of #248

The alternatives calculation statements are set to 'debug' instead of
'info'.

The log statement at the beginning and end of the v2/* routes are set to
'info' and parameters are removed, spdlog will associate a timestamp with
the log, so no need to display the application's time.

If a catchall exception occurs, the log level is 'error'.

TODO
Cleanup the 'debug' statements and set a few as 'trace'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant