Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some test for the AllNodes code path in the benchmarks #213

Open
greenscientist opened this issue Dec 1, 2022 · 1 comment
Open

Add some test for the AllNodes code path in the benchmarks #213

greenscientist opened this issue Dec 1, 2022 · 1 comment

Comments

@greenscientist
Copy link
Contributor

greenscientist commented Dec 1, 2022 •
edited

Benchmark do not currently account for this code path. Since we are splitting the calculate path into allNodes and single result, we should add benchmark for it.
@greenscientist
Copy link
Contributor Author

@tahini If you had thought for this, let me know.

@greenscientist greenscientist changed the title Add some test for the AllNode code path in the benchmarks Add some test for the AllNodes code path in the benchmarks Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@greenscientist