Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore households and places if/when required #167

Open
greenscientist opened this issue Jul 18, 2022 · 0 comments
Open

Restore households and places if/when required #167

greenscientist opened this issue Jul 18, 2022 · 0 comments

Comments

@greenscientist
Copy link
Contributor

To simplify some of the refactoring work currently done, we have commented out/removed most of the fonctionnalities for Households and Places. This will make less code to manage as we are moving stuff around.
They are not used anywhere, so no functionalities are lost. We once the code stop moving, it will be easy to add back
greenscientist added a commit to greenscientist/trRouting that referenced this issue Jul 19, 2022
@greenscientist
Migrate DataSource vector and index map to a single UUID:DataSource map
7e0ba1e 
Added == and != operators to DataSource

Since Person and OdTrip now store a reference to a DataSource, we added constructor for those.

While doing this, we observed that Households and Places are not used anywhere in the calculation.
We have commented out those files, references and initialization functions. Those were marked
with a TODO chairemobilite#167 (task number to restore them when needed/refactoring done)
@greenscientist greenscientist mentioned this issue Jul 19, 2022
Merged
greenscientist added a commit to greenscientist/trRouting that referenced this issue Jul 27, 2022
@greenscientist
Migrate DataSource vector and index map to a single UUID:DataSource map
56b38d7 
Added == and != operators to DataSource

Since Person and OdTrip now store a reference to a DataSource, we added constructor for those.

While doing this, we observed that Households and Places are not used anywhere in the calculation.
We have commented out those files, references and initialization functions. Those were marked
with a TODO chairemobilite#167 (task number to restore them when needed/refactoring done)
greenscientist added a commit to greenscientist/trRouting that referenced this issue Jul 27, 2022
@greenscientist
Migrate DataSource vector and index map to a single UUID:DataSource map
e35ff98 
Added == and != operators to DataSource

Since Person and OdTrip now store a reference to a DataSource, we added constructor for those.

While doing this, we observed that Households and Places are not used anywhere in the calculation.
We have commented out those files, references and initialization functions. Those were marked
with a TODO chairemobilite#167 (task number to restore them when needed/refactoring done)
greenscientist added a commit that referenced this issue Jul 27, 2022
@greenscientist
Migrate DataSource vector and index map to a single UUID:DataSource map
d8c4ecf 
Added == and != operators to DataSource

Since Person and OdTrip now store a reference to a DataSource, we added constructor for those.

While doing this, we observed that Households and Places are not used anywhere in the calculation.
We have commented out those files, references and initialization functions. Those were marked
with a TODO #167 (task number to restore them when needed/refactoring done)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@greenscientist