Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should node (latest) images have a shell? #1969

Open
macabu opened this issue Dec 19, 2023 · 3 comments
Open

Should node (latest) images have a shell? #1969

macabu opened this issue Dec 19, 2023 · 3 comments
Labels
needs-triage applied to all new customer/user issues. Removed after triage occurs.

Comments

@macabu
Copy link

macabu commented Dec 19, 2023

Which image/versions are related to this issue/feature request?

cgr.dev/chainguard/node-lts:latest@sha256:4d282d59c135c0d4d90f1228d5bae9827da8aed37153bba3fee98f9f42d103fc

Issue/Feature description

I was reading this page and it says:

Having a package manager and the ability to log into the image to debug any issues is very important at development time, but becomes unnecessary (and less safe) when talking about production environments. That’s why we recommend using a distroless variant for production workloads.

It implied to me that the node images wouldn't contain a shell, like the php one doesn't.

Are they required to have a shell for some other reason?

Sorry if this has been raised before but I couldn't find the issue!

@macabu macabu added the needs-triage applied to all new customer/user issues. Removed after triage occurs. label Dec 19, 2023
@max-allan-cgr
Copy link
Contributor

Hi @macabu ,
We are actually working on removing a lot of things (like the shell) from the node images.

Thanks for the feedback!

@macabu
Copy link
Author

macabu commented Apr 13, 2024

Thanks for the reply, great news! 🚀

@smoser
Copy link
Contributor

smoser commented Apr 24, 2024

#2563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage applied to all new customer/user issues. Removed after triage occurs.
Projects
None yet
Development

No branches or pull requests

3 participants